-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use codeclysm/extract
and remove custom implementation
#867
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
==========================================
+ Coverage 19.68% 20.59% +0.90%
==========================================
Files 46 46
Lines 3672 3467 -205
==========================================
- Hits 723 714 -9
+ Misses 2855 2653 -202
- Partials 94 100 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The tools are the one coming with the cores installed in the builder
we remove the root dir if we find one. The logic is similar to: https://github.com/arduino/arduino-cli/blob/7a146635aaa740e748b84bf8fbfdccf1cc420c61/arduino/resources/install.go#L34
9ea870a
to
37e9e8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
Please check if the PR fulfills these requirements
before creating one)
enhancement/security
We use
codeclysm/extract
in our arduino GOLang projects. This is the only one that is using a custom implementation for extracting files.Use
codeclysm/extract
which already include security fixes (codeclysm/extract#14)Nop