-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Taskfile): add race detector and watcher for local development #1003
Conversation
A data race is detected on shutdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1003 +/- ##
=======================================
Coverage 20.14% 20.14%
=======================================
Files 42 42
Lines 3221 3221
=======================================
Hits 649 649
Misses 2487 2487
Partials 85 85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0a0c128
to
3e36a77
Compare
Another DATA-RACE when the port is closed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch.
How do we want to handle those race problems?
- Do we want to open a dedicated issue for each of them
- Do we want to open a generic issue and reference both problems in the description
- Do we want to address them in this same PR?
I think there are other data races in the code base :( We could merge this PR, and open an issue for each data race detected. |
Please check if the PR fulfills these requirements
before creating one)
Add
task install
command to install local dependencies, andtask run
command to run the service locally with the auto-reload and race detector enabled.