Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of deprecated sprintf in IPAddress #210

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

jboynes
Copy link
Contributor

@jboynes jboynes commented Sep 8, 2023

Partial fix for #209 by replacing use of sprintf with snprintf
Remove warning suppression added in #208

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (66aa7db) 95.52% compared to head (0365dc3) 95.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files          16       16           
  Lines        1072     1072           
=======================================
  Hits         1024     1024           
  Misses         48       48           
Files Changed Coverage Δ
api/IPAddress.cpp 94.52% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@per1234 per1234 added the bug label Sep 12, 2023
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aentinger aentinger merged commit bbce6f6 into arduino:master Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants