Added processing of fractional time, setting of currentEpoch, sanity checking of received timestamps, and new example. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the exact NTP time. Added sanity checking of received timestamp before using it. Added millis() rollover protection in getEpochTime(). Added new function, setEpochTime(), to set NTPClient's internal currentEpoch from hardware RTC time. Changed the default updateInterval to 1 hour. Added 'Advanced_with_RTC' example to demonstrate new capabilities and accuracy.
|
|
|
I have couple of points:
|
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I humbly present my contribution to the NTPClient library.
I've tried not to change much of the way the library works and aimed to improve on it instead.
Here are the changes that I made:
Added processing of fractional time in forceUpdate() to allow syncing to the exact NTP time.
Added sanity checking of received timestamp before using it.
Added millis() rollover protection in getEpochTime().
Added new function, setEpochTime(), to set NTPClient's internal currentEpoch from hardware RTC time.
Changed the default updateInterval to 1 hour.
Added 'Advanced_with_RTC' example to demonstrate new capabilities and accuracy.
Sincerely,
afdp777