Remove redundant spaces from comment text #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some redundant spaces were present in the comments Some of these followed a period. Although two spaces after a period were sometimes recommended in previous eras, modern practice is universally a single space: https://www.chicagomanualofstyle.org/qanda/data/faq/topics/OneSpaceorTwo/faq0006.html Regardless of whether it is correct according to standard practice, it might be reasonable to retain double spaces if this were a well established convention in the project. That is not the case here. The majority of the content uses only a single space, so the double spaces are inconsistent in addition to being incorrect. There were also some occurrences of redundant spaces within sentences, which is never correct.
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some redundant spaces were present in the comments
Some of these followed a period. Although two spaces after a period were sometimes recommended in previous eras, modern practice is universally a single space:
https://www.chicagomanualofstyle.org/qanda/data/faq/topics/OneSpaceorTwo/faq0006.html
Regardless of whether it is correct according to standard practice, it might be reasonable to retain double spaces if this were a well established convention in the project. That is not the case here. The majority of the content uses only a single space, so the double spaces are inconsistent in addition to being incorrect.
There were also some occurrences of redundant spaces within sentences, which is never correct.
Resolves (partially) #8