Skip to content

feat: NotecardConnectionManager #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2024
Merged

feat: NotecardConnectionManager #122

merged 2 commits into from
Aug 23, 2024

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Jul 20, 2024

No description provided.

@zfields zfields marked this pull request as draft July 20, 2024 18:31
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 20, 2024
@zfields zfields force-pushed the notecard branch 4 times, most recently from 6437fb1 to c3db60b Compare July 23, 2024 12:59
pennam
pennam reviewed Jul 25, 2024
View reviewed changes
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jul 25, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jul 25, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jul 25, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jul 25, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jul 25, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jul 25, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jul 25, 2024
@zfields zfields force-pushed the notecard branch 6 times, most recently from 615cc71 to 434f694 Compare July 25, 2024 19:02
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jul 26, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jul 26, 2024
@zfields zfields force-pushed the notecard branch 2 times, most recently from 9611130 to 23f28a8 Compare July 30, 2024 20:00
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 14, 2024
pennam
pennam reviewed Aug 14, 2024
View reviewed changes
@zfields zfields force-pushed the notecard branch 10 times, most recently from 7bae6d2 to e89dba6 Compare August 21, 2024 00:20
@github-actions GitHub Actions
Copy link

Memory usage change @ e89dba6

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +384 - +384 +0.01 - +0.01 🔺 +8 - +8 0.0 - 0.0
arduino:mbed:envie_m7 N/A N/A N/A N/A
arduino:mbed_edge:edge_control 🔺 +296 - +296 +0.03 - +0.03 🔺 +8 - +8 0.0 - 0.0
arduino:mbed_giga:giga 🔺 +296 - +296 +0.02 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 +345 - +345 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 +296 - +296 +0.02 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 🔺 +360 - +360 +0.02 - +0.02 🔺 +32 - +32 +0.01 - +0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 +344 - +344 +0.02 - +0.02 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkr1000 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrgsm1400 🔺 +352 - +352 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrnb1500 🔺 +336 - +336 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrwan1300 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrwan1310 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrwifi1010 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:nano_33_iot 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
esp32:esp32:esp32 🔺 +352 - +352 +0.03 - +0.03 🔺 +8 - +8 0.0 - 0.0
esp8266:esp8266:huzzah N/A N/A N/A N/A
Click for full report table
Board examples/ConnectionHandlerDemo
flash		 % examples/ConnectionHandlerDemo
RAM for global variables		 % examples/ConnectionHandlerDemo-Notecard
flash		 % examples/ConnectionHandlerDemo-Notecard
RAM for global variables		 %
arduino:esp32:nano_nora 384 0.01 8 0.0 N/A N/A N/A N/A
arduino:mbed:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_edge:edge_control 296 0.03 8 0.0 N/A N/A N/A N/A
arduino:mbed_giga:giga 296 0.02 0 0.0 N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect 345 0.0 0 0.0 N/A N/A N/A N/A
arduino:mbed_nicla:nicla_vision 296 0.02 0 0.0 N/A N/A N/A N/A
arduino:mbed_opta:opta 360 0.02 32 0.01 N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 344 0.02 0 0.0 N/A N/A N/A N/A
arduino:renesas_uno:unor4wifi 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkr1000 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrgsm1400 352 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrnb1500 336 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrwan1300 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrwan1310 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrwifi1010 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:nano_33_iot 344 0.13 8 0.02 N/A N/A N/A N/A
esp32:esp32:esp32 352 0.03 8 0.0 N/A N/A N/A N/A
esp8266:esp8266:huzzah N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV 
Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%,examples/ConnectionHandlerDemo-Notecard<br>flash,%,examples/ConnectionHandlerDemo-Notecard<br>RAM for global variables,%
arduino:esp32:nano_nora,384,0.01,8,0.0,N/A,N/A,N/A,N/A
arduino:mbed:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_edge:edge_control,296,0.03,8,0.0,N/A,N/A,N/A,N/A
arduino:mbed_giga:giga,296,0.02,0,0.0,N/A,N/A,N/A,N/A
arduino:mbed_nano:nanorp2040connect,345,0.0,0,0.0,N/A,N/A,N/A,N/A
arduino:mbed_nicla:nicla_vision,296,0.02,0,0.0,N/A,N/A,N/A,N/A
arduino:mbed_opta:opta,360,0.02,32,0.01,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,344,0.02,0,0.0,N/A,N/A,N/A,N/A
arduino:renesas_uno:unor4wifi,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkr1000,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrgsm1400,352,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrnb1500,336,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrwan1300,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrwan1310,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrwifi1010,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:nano_33_iot,344,0.13,8,0.02,N/A,N/A,N/A,N/A
esp32:esp32:esp32,352,0.03,8,0.0,N/A,N/A,N/A,N/A
esp8266:esp8266:huzzah,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 21, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 21, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 21, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 21, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 21, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 21, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 21, 2024
@zfields zfields force-pushed the notecard branch 2 times, most recently from 380cd6d to 9c0d761 Compare August 21, 2024 17:18
@github-actions GitHub Actions
Copy link

Memory usage change @ 9c0d761

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +384 - +384 +0.01 - +0.01 🔺 +8 - +8 0.0 - 0.0
arduino:mbed:envie_m7 N/A N/A N/A N/A
arduino:mbed_edge:edge_control 🔺 +296 - +296 +0.03 - +0.03 🔺 +8 - +8 0.0 - 0.0
arduino:mbed_giga:giga 🔺 +296 - +296 +0.02 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 +345 - +345 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 +296 - +296 +0.02 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 🔺 +360 - +360 +0.02 - +0.02 🔺 +32 - +32 +0.01 - +0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 +344 - +344 +0.02 - +0.02 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkr1000 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrgsm1400 🔺 +352 - +352 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrnb1500 🔺 +336 - +336 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrwan1300 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrwan1310 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrwifi1010 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:nano_33_iot 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
esp32:esp32:esp32 🔺 +352 - +352 +0.03 - +0.03 🔺 +8 - +8 0.0 - 0.0
esp8266:esp8266:huzzah 🔺 +448 - +448 +0.04 - +0.04 🔺 +120 - +120 +0.15 - +0.15
Click for full report table
Board examples/ConnectionHandlerDemo
flash		 % examples/ConnectionHandlerDemo
RAM for global variables		 % examples/ConnectionHandlerDemo-Notecard
flash		 % examples/ConnectionHandlerDemo-Notecard
RAM for global variables		 %
arduino:esp32:nano_nora 384 0.01 8 0.0 N/A N/A N/A N/A
arduino:mbed:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_edge:edge_control 296 0.03 8 0.0 N/A N/A N/A N/A
arduino:mbed_giga:giga 296 0.02 0 0.0 N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect 345 0.0 0 0.0 N/A N/A N/A N/A
arduino:mbed_nicla:nicla_vision 296 0.02 0 0.0 N/A N/A N/A N/A
arduino:mbed_opta:opta 360 0.02 32 0.01 N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 344 0.02 0 0.0 N/A N/A N/A N/A
arduino:renesas_uno:unor4wifi 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkr1000 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrgsm1400 352 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrnb1500 336 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrwan1300 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrwan1310 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrwifi1010 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:nano_33_iot 344 0.13 8 0.02 N/A N/A N/A N/A
esp32:esp32:esp32 352 0.03 8 0.0 N/A N/A N/A N/A
esp8266:esp8266:huzzah 448 0.04 120 0.15
Click for full report CSV 
Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%,examples/ConnectionHandlerDemo-Notecard<br>flash,%,examples/ConnectionHandlerDemo-Notecard<br>RAM for global variables,%
arduino:esp32:nano_nora,384,0.01,8,0.0,N/A,N/A,N/A,N/A
arduino:mbed:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_edge:edge_control,296,0.03,8,0.0,N/A,N/A,N/A,N/A
arduino:mbed_giga:giga,296,0.02,0,0.0,N/A,N/A,N/A,N/A
arduino:mbed_nano:nanorp2040connect,345,0.0,0,0.0,N/A,N/A,N/A,N/A
arduino:mbed_nicla:nicla_vision,296,0.02,0,0.0,N/A,N/A,N/A,N/A
arduino:mbed_opta:opta,360,0.02,32,0.01,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,344,0.02,0,0.0,N/A,N/A,N/A,N/A
arduino:renesas_uno:unor4wifi,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkr1000,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrgsm1400,352,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrnb1500,336,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrwan1300,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrwan1310,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrwifi1010,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:nano_33_iot,344,0.13,8,0.02,N/A,N/A,N/A,N/A
esp32:esp32:esp32,352,0.03,8,0.0,N/A,N/A,N/A,N/A
esp8266:esp8266:huzzah,448,0.04,120,0.15,,,,

@github-actions GitHub Actions
Copy link

Memory usage change @ df5c827

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +384 - +384 +0.01 - +0.01 🔺 +8 - +8 0.0 - 0.0
arduino:mbed:envie_m7 N/A N/A N/A N/A
arduino:mbed_edge:edge_control 🔺 +296 - +296 +0.03 - +0.03 🔺 +8 - +8 0.0 - 0.0
arduino:mbed_giga:giga 🔺 +296 - +296 +0.02 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 +345 - +345 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 +296 - +296 +0.02 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 🔺 +360 - +360 +0.02 - +0.02 🔺 +32 - +32 +0.01 - +0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 +344 - +344 +0.02 - +0.02 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkr1000 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrgsm1400 🔺 +352 - +352 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrnb1500 🔺 +336 - +336 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrwan1300 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrwan1310 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrwifi1010 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:nano_33_iot 🔺 +344 - +344 +0.13 - +0.13 🔺 +8 - +8 +0.02 - +0.02
esp32:esp32:esp32 🔺 +352 - +352 +0.03 - +0.03 🔺 +8 - +8 0.0 - 0.0
esp8266:esp8266:huzzah 🔺 +448 - +448 +0.04 - +0.04 🔺 +120 - +120 +0.15 - +0.15
Click for full report table
Board examples/ConnectionHandlerDemo
flash		 % examples/ConnectionHandlerDemo
RAM for global variables		 % examples/ConnectionHandlerDemo-Notecard
flash		 % examples/ConnectionHandlerDemo-Notecard
RAM for global variables		 %
arduino:esp32:nano_nora 384 0.01 8 0.0 N/A N/A N/A N/A
arduino:mbed:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_edge:edge_control 296 0.03 8 0.0 N/A N/A N/A N/A
arduino:mbed_giga:giga 296 0.02 0 0.0 N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect 345 0.0 0 0.0 N/A N/A N/A N/A
arduino:mbed_nicla:nicla_vision 296 0.02 0 0.0 N/A N/A N/A N/A
arduino:mbed_opta:opta 360 0.02 32 0.01 N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 344 0.02 0 0.0 N/A N/A N/A N/A
arduino:renesas_uno:unor4wifi 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkr1000 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrgsm1400 352 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrnb1500 336 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrwan1300 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrwan1310 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:mkrwifi1010 344 0.13 8 0.02 N/A N/A N/A N/A
arduino:samd:nano_33_iot 344 0.13 8 0.02 N/A N/A N/A N/A
esp32:esp32:esp32 352 0.03 8 0.0 N/A N/A N/A N/A
esp8266:esp8266:huzzah 448 0.04 120 0.15
Click for full report CSV 
Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%,examples/ConnectionHandlerDemo-Notecard<br>flash,%,examples/ConnectionHandlerDemo-Notecard<br>RAM for global variables,%
arduino:esp32:nano_nora,384,0.01,8,0.0,N/A,N/A,N/A,N/A
arduino:mbed:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_edge:edge_control,296,0.03,8,0.0,N/A,N/A,N/A,N/A
arduino:mbed_giga:giga,296,0.02,0,0.0,N/A,N/A,N/A,N/A
arduino:mbed_nano:nanorp2040connect,345,0.0,0,0.0,N/A,N/A,N/A,N/A
arduino:mbed_nicla:nicla_vision,296,0.02,0,0.0,N/A,N/A,N/A,N/A
arduino:mbed_opta:opta,360,0.02,32,0.01,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,344,0.02,0,0.0,N/A,N/A,N/A,N/A
arduino:renesas_uno:unor4wifi,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkr1000,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrgsm1400,352,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrnb1500,336,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrwan1300,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrwan1310,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:mkrwifi1010,344,0.13,8,0.02,N/A,N/A,N/A,N/A
arduino:samd:nano_33_iot,344,0.13,8,0.02,N/A,N/A,N/A,N/A
esp32:esp32:esp32,352,0.03,8,0.0,N/A,N/A,N/A,N/A
esp8266:esp8266:huzzah,448,0.04,120,0.15,,,,

@pennam pennam merged commit d755eb5 into arduino-libraries:master Aug 23, 2024
22 checks passed
@zfields zfields deleted the notecard branch March 4, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennam pennam pennam approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zfields @pennam @per1234