Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix size deltas report infrastructure configuration #40

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Fix size deltas report infrastructure configuration #40

merged 2 commits into from
Feb 21, 2024

Commits on Feb 21, 2024

  1. Revert "Fix regression: report size delta size on PR. (#39)" 

    This reverts commit cac25ed.
    @aentinger
    aentinger committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    ab427be View commit details
    Browse the repository at this point in the history

  2. Correct workflow artifact name pattern in size deltas report workflow 

    The "sketches-reports-source" input of the "arduino/report-size-deltas" GitHub Actions action defines the regular
expression that matches the names of the sketches report workflow artifacts produced by the "Compile Examples" workflow.

The key string in the names of these artifacts was set to "sketches-report" when the "Compile Examples" workflow was
adjusted for compatibility with the breaking changes introduced by updating to version 4.x of the workflow's
"actions/upload-artifact" GitHub Actions action dependency. The pattern set in the size deltas report workflow was
"sketches-reports". The "s" at the end of that pattern caused it to no longer match against the key string in the
artifact names after that adjustment of the "Compile Examples" workflow, resulting in size deltas reports no longer
being generated by the workflow.

Although a minimal fix would be to simply remove the "s" from the end of the pattern, the decision was made to use a
more strict regular expression. This will make it easier for maintainers and contributors to understand that this value
is a regular expression and the exact nature of how that regular expression functio
    @aentinger
    aentinger committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    c9ec0e4 View commit details
    Browse the repository at this point in the history