This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Added partial support for generating sketch prototypes #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of the sketch conversion process.
This is because the function returns the path to the header file and not just whether is exists or not. This change also caused separation of the function into a dedicated file
It detects which prototypes need to be generated, based on the def-dec matching ability previously added
Added utility function to escape semicolons in a string and vice-versa Fixed bug in `list_max_index` utility function
It now fully supports both platform header & prototypes insertion
Fixed small function argument-stripping bug
Uncommented examples other than 'sketch'
MrPointer
force-pushed
the
feature/sketch-func-prototypes
branch
from
83255b2 to
6e060ab
Compare
On Linux CMake might find avr-gcc first inside ccache folder which leads to wrong ar/ranlib detection. On Fedora 30 at least, it leads to link errors because it uses avr-ar/ranlib instead of avr-gcc-ar/ranlib. Signed-off-by: Alexis Jeandet <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support is partial due to the fact that complete prototype generation just can't be achieved with CMake - Further discussion can be found at the comments of #32.
Currently, this work redesigns how sketches are converted, but also adds basic prototype generation - Somewhat dumb, as it sometimes generates prototypes even when a matching declaration exists.
As described in #32, this whole conversion process should be done outside the framework, thus it should be developed as an external tool in a better-suited environment, such as Python.