Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guard clauses for SmartEnum #533

Merged
merged 13 commits into from
Sep 11, 2024
Merged

Add guard clauses for SmartEnum #533

merged 13 commits into from
Sep 11, 2024

Conversation

Asafima
Copy link
Contributor

@Asafima Asafima commented Jul 15, 2024

Added SmartEnumOutOfRange using Ardalis.GuardClauses with two method overloads (int, and generic type).

Closes #528

TODO: Update Readme.md once this pull request is approved and nuget is created.

@Asafima
Copy link
Contributor Author

Asafima commented Jul 29, 2024

@ardalis Hey Ardalis,
Saw you tried to merge the pull request. The build fails because of System.Text.Json vulnerability.
Do you need me to do anything with this pull request?

@ardalis
Copy link
Owner

ardalis commented Jul 29, 2024

Update System.Text.Json if you have a chance otherwise I'll get to it eventually.

@Asafima
Copy link
Contributor Author

Asafima commented Jul 30, 2024

@ardalis , I have fixed the CS1591 (warning as error).

  1. Do you want me to add a publish-smartenumguardclauses.yml file (using the same template you use for all publish ymls)?
  2. Do you want me to add a README.md to the SmartEnumGuardClauses csproj? or maybe update it to use the main README file?currently no project has a README file baked into it except for SmartEnum.

@ardalis
Copy link
Owner

ardalis commented Aug 2, 2024

@Asafima

  1. Sure that would be helpful.
  2. Your call on the README. Probably good for it to have its own and just link to SmartEnum for more info. Would keep it shorter/simpler.

@Asafima
Copy link
Contributor Author

Asafima commented Aug 4, 2024

@ardalis
Awesome. Added github-actions yml file for pipeline, and a readme file for this nuget with references to SmartEnum.

@Asafima
Copy link
Contributor Author

Asafima commented Aug 19, 2024

@ardalis Hey, any new on this PR?

@ardalis ardalis merged commit 00b8f41 into ardalis:main Sep 11, 2024
@ardalis
Copy link
Owner

ardalis commented Sep 11, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Guard fro SmartEnum Out of Range
2 participants