Use connection state to optimise packet type detection #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zefir-git
force-pushed
the
37-feature-improved-packet-detection-based-on-state
branch
from
de50d07
to
f3b2f1c
Compare
kai-gitt
previously approved these changes
Aug 14, 2023
kai-gitt
approved these changes
Aug 14, 2023
zefir-git
deleted the
37-feature-improved-packet-detection-based-on-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minecraft likes to re-use packet IDs. This PR first checks if the packet type's expected connection state matches the actual state of the connection sending the packet. If there is no match, we can quickly skip this type and continue checking another.