Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding x/cwerrors module #546

Merged
merged 33 commits into from
Mar 22, 2024
Merged

feat: adding x/cwerrors module #546

merged 33 commits into from
Mar 22, 2024

Conversation

spoo-bar
Copy link
Contributor

Closes: #544

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 67.12329% with 192 lines in your changes are missing coverage. Please review.

Project coverage is 64.72%. Comparing base (d736d9e) to head (310a1a1).

Files Patch % Lines
x/cwerrors/keeper/sudo_errors.go 50.80% 47 Missing and 14 partials ⚠️
x/cwerrors/types/events.go 0.00% 30 Missing ⚠️
x/cwerrors/types/msg.go 0.00% 20 Missing ⚠️
x/cwerrors/keeper/subscriptions.go 70.96% 12 Missing and 6 partials ⚠️
x/cwerrors/module.go 65.21% 16 Missing ⚠️
x/cwerrors/keeper/grpc_query.go 79.06% 6 Missing and 3 partials ⚠️
x/cwerrors/types/genesis.go 20.00% 8 Missing ⚠️
x/cwerrors/types/codec.go 53.33% 7 Missing ⚠️
x/cwerrors/abci.go 78.57% 3 Missing and 3 partials ⚠️
x/cwerrors/genesis.go 57.14% 3 Missing and 3 partials ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
+ Coverage   64.47%   64.72%   +0.24%     
==========================================
  Files         102      118      +16     
  Lines        5368     5950     +582     
==========================================
+ Hits         3461     3851     +390     
- Misses       1726     1886     +160     
- Partials      181      213      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spoo-bar spoo-bar marked this pull request as ready for review March 14, 2024 10:16
@spoo-bar spoo-bar requested a review from a team as a code owner March 14, 2024 10:16
@@ -0,0 +1,87 @@
# State

Section describes all stored by the module objects and their storage keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken sentence?

Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Want a review from @fdymylja as well, please.

Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for delay, LGTM!

@spoo-bar spoo-bar merged commit 9ae0d64 into main Mar 22, 2024
9 of 10 checks passed
@spoo-bar spoo-bar deleted the spoorthi/errors-module branch March 22, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIP: x/errors module
3 participants