Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: snapshot db remove hardcoding #514

Merged
merged 3 commits into from
Dec 1, 2023
Merged

fix: snapshot db remove hardcoding #514

merged 3 commits into from
Dec 1, 2023

Conversation

spoo-bar
Copy link
Contributor

  • Fix snapshot db being hardcoded from goleveldb to based on config

@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1046cae) 66.02% compared to head (34f67a7) 66.02%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   66.02%   66.02%           
=======================================
  Files          63       63           
  Lines        3909     3909           
=======================================
  Hits         2581     2581           
  Misses       1200     1200           
  Partials      128      128

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spoo-bar spoo-bar marked this pull request as ready for review November 30, 2023 12:32
@spoo-bar spoo-bar requested a review from a team as a code owner November 30, 2023 12:32
@spoo-bar spoo-bar requested a review from zanicar November 30, 2023 12:32
fdymylja
fdymylja approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spoo-bar spoo-bar merged commit 28cd116 into main Dec 1, 2023
9 checks passed
@spoo-bar spoo-bar deleted the spoorthi/removing-db-hardcoding branch December 1, 2023 16:52
spoo-bar added a commit that referenced this pull request Dec 4, 2023
@spoo-bar
fix: snapshot db remove hardcoding (#514)
9f5a730 
* removing hardcode of snapshot db backend

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanicar zanicar zanicar approved these changes

@fdymylja fdymylja fdymylja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spoo-bar @fdymylja @zanicar