Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Cleanup #1317

Merged
merged 16 commits into from
Feb 20, 2025
Merged

[4.x] Cleanup #1317

merged 16 commits into from
Feb 20, 2025

Conversation

stancl
Copy link
Member

@stancl stancl commented Feb 20, 2025

Breaking changes:

  • asset_helper_tenancy -> asset_helper_override
  • FortifyRouteBootstrapper usage changed (see docblocks/diff)
  • UserImpersonation::leave() -> stopImpersonating()

Other changes:

  • Cleaned up config/TSP stub
  • Make pending tenants timestamp cast configurable
  • Make UrlGeneratorOverride and related to respect custom parameter & column names (if configured). Doesn't work with /{tenant:slug} syntax
  • Fix queue app tests CI workflow

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.74%. Comparing base (eac88dc) to head (08f58bf).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Overrides/TenancyUrlGenerator.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1317      +/-   ##
============================================
- Coverage     84.75%   84.74%   -0.02%     
- Complexity     1056     1063       +7     
============================================
  Files           177      177              
  Lines          3096     3100       +4     
============================================
+ Hits           2624     2627       +3     
- Misses          472      473       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stancl stancl marked this pull request as ready for review February 20, 2025 19:48
@stancl stancl merged commit 657e165 into master Feb 20, 2025
11 checks passed
@stancl stancl deleted the 2025-cleanup branch February 20, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants