-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve EFI bootloader installation #2312
Conversation
752b9da
to
19b8d90
Compare
would it be possible to give the user a prompt, upon ultimate failure, to abort advancing on the entirety of the archinstall scripts, or to continue with a potentially failed grub-install? (or check for an archinstall flag to allow prompt/silent mode or something) - suggested grub-install errors as a my example in #2378 edit; i tested this on an ipxe'd bios-install and it has still failed (dropped it on top of the current installer.py, did not check for rebase'ing ect) ( it = https://github.com/archlinux/archinstall/blob/5b9574d3acbe5a106543e16d5cc02e1ed860d7b1/archinstall/lib/installer.py ) |
Awesome work, I'd like to marge this. |
I believe that "fixed" the issue because it prevented grub-install from adding the EFI entry in the first place. The removable flag treats the destination as a removable drive, only adding a standard Also, this PR might actually fix that issue due to automatically retrying the installation upon such an error. |
I could try, but it would make the installation process less "automatic." This might be in the scope of a future PR to handle common errors during installation. |
I could never get a hold of hardware that could trigger the error. And now that we know about the issue, if it comes back we could add back this flag. |
im wondering now if adding different behaviors for each type of error would be useful? for example for my "fun" hardware the efibootmgr can fail but is not an issue due to having to teak the bios manually anyways; and skipping it by adding |
Those checks and tweaks would improve reliability if nothing else, and it's a godsend if we could get there. Because this and disk operations have always been a painpoint. |
PR Description:
Some improvements to the installation of bootloaders on devices with UEFI:
--bootloader-id
option, using the defaultgrub
instead--debug
option, which prints a lot of unnecessary info and may enable a debug flag--removable
option, which prevents an EFI entry from being created/EFI/BOOT/BOOTxxx.EFI/
, has been implemented manuallyefibootmgr
Tests and Checks