Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic package selection #217

Merged
merged 11 commits into from
Oct 22, 2024

Conversation

krumelmonster
Copy link
Contributor

Checklist

  • Admin:
    • No duplicate PRs
  • Integration:
    • Update unit tests
    • Update shell completions
    • Update configuration file
  • Documentation:
    • Update usage function
    • Update mandoc
    • Update readme
    • Update locales
  • Release:
    • Update change log
    • Update DOWNGRADE_VERSION

Description

The --any-candidate option picks the first candidate instead of presenting options with fzf. In conjunction with --ignore never (or always) it allows for noninteractive downgrades. It may not be a complete fix for #118 but it's enough to set a bunch of packages to a version of choice and not care whether they are sourced locally or from the archives.

bin/downgrade Outdated Show resolved Hide resolved
@krumelmonster krumelmonster changed the title introduce --any-candidate to allow noninteractive use automatic package selection Oct 4, 2023
@krumelmonster krumelmonster marked this pull request as draft October 4, 2023 14:14
@krumelmonster krumelmonster marked this pull request as ready for review October 5, 2023 20:08
README.md Outdated Show resolved Hide resolved
bin/downgrade Show resolved Hide resolved
doc/downgrade.8.md Outdated Show resolved Hide resolved
doc/downgrade.8.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
bin/downgrade Outdated Show resolved Hide resolved
bin/downgrade Outdated Show resolved Hide resolved
@krumelmonster
Copy link
Contributor Author

Can we merge or should I fixup these minor fixes first?

Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM except for fixing up the escaped -- in the man-page. I'll merge once that's fixed.

doc/downgrade.8.md Outdated Show resolved Hide resolved
@pbrisbin
Copy link
Member

I'll merge once that's fixed.

Oops, and the test failures of course. Seems there's a syntax error somewhere 🤔

@pbrisbin
Copy link
Member

Let me know when you've gotten tests passing, or if you need any help with that.

@krumelmonster krumelmonster force-pushed the noninteractive branch 3 times, most recently from 04211fa to b802042 Compare October 21, 2024 17:44
@krumelmonster
Copy link
Contributor Author

whoops this may have been a bit too much force pushing. I only made the minor changes we've mentioned before but then I also rebased a bit.
https://github.com/archlinux-downgrade/downgrade/compare/d7e2077597c8429c5ec2f9d319da5170dab7549b..b80204251a70b26e2a77eeb1a3008829ce18ed51

@krumelmonster
Copy link
Contributor Author

krumelmonster commented Oct 22, 2024

I updated the tests that broke due to the split-up of search_packages into search_ala and search_cache and rebased into the respective commit d82aa21 and I think we're now good to go. Workflows should succeed once you run them; tested here krumelmonster#1

I'm tempted to add some test cases for my changes themselves (cram looks really cool!) but that will be a task for another day (preferably in a later pr).

Again Sorry for the rebase mess and the mangling with #231 , changes since I started rebasing are:

  • test cases
  • syntax error due to missing ; in the {} (interestingly only CI catched this and bash ate it on my local arch)
  • escaping the -- in the manpage
  • make locale -- I believe I may have made a mess here because POT-Creation-Date has changed, let me know if this needs fixing

overall diff since before first force push: https://github.com/archlinux-downgrade/downgrade/compare/d7e2077597c8429c5ec2f9d319da5170dab7549b..d75b63242be75441c9891e659f52cff9b14e71ba

@pbrisbin
Copy link
Member

No worries, thanks for sticking with it!

@pbrisbin pbrisbin merged commit c4b6d22 into archlinux-downgrade:main Oct 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants