-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automatic package selection #217
automatic package selection #217
Conversation
Can we merge or should I fixup these minor fixes first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM except for fixing up the escaped --
in the man-page. I'll merge once that's fixed.
Oops, and the test failures of course. Seems there's a syntax error somewhere 🤔 |
d7e2077
to
04b681d
Compare
Let me know when you've gotten tests passing, or if you need any help with that. |
04211fa
to
b802042
Compare
whoops this may have been a bit too much force pushing. I only made the minor changes we've mentioned before but then I also rebased a bit. |
b802042
to
7a96085
Compare
…presenting options with fzf
…und in cache splits search_packages() into search_ala() and search_cache() leading to changes in tests
…atest --cache-preferred
7a96085
to
4369540
Compare
4369540
to
b1d25dd
Compare
b1d25dd
to
d75b632
Compare
I updated the tests that broke due to the split-up of I'm tempted to add some test cases for my changes themselves (cram looks really cool!) but that will be a task for another day (preferably in a later pr). Again Sorry for the rebase mess and the mangling with #231 , changes since I started rebasing are:
overall diff since before first force push: https://github.com/archlinux-downgrade/downgrade/compare/d7e2077597c8429c5ec2f9d319da5170dab7549b..d75b63242be75441c9891e659f52cff9b14e71ba |
No worries, thanks for sticking with it! |
a7f3b33
to
a3bcd7b
Compare
a3bcd7b
to
038591d
Compare
Checklist
DOWNGRADE_VERSION
Description
The
--any-candidate
option picks the first candidate instead of presenting options with fzf. In conjunction with--ignore never
(or always) it allows for noninteractive downgrades. It may not be a complete fix for #118 but it's enough to set a bunch of packages to a version of choice and not care whether they are sourced locally or from the archives.