This repository has been archived by the owner on May 31, 2020. It is now read-only.
Updating README content - Issue 23 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cies, outlines types of visuals created with notebook
ruebot
suggested changes
Mar 7, 2019
README.md
Outdated
| @@ -38,6 +38,10 @@ python -m nltk.downloader punkt vader_lexicon stopwords | |||
| jupyter notebook | |||
| ``` | |||
|
|
|||
| ### Docker | |||
|
|
|||
| Docker is a container-based virtual machine system that bundles dependencies together, this means you can build the docker image and it will work out of the box. To run the Jupyter Notebook via Docker, there are two options, Docker Hub and Docker Locally. | |||
There was a problem hiding this comment.
Capitalize Docker: you can build the Docker image
README.md
Outdated
|
|
||
| There are several types of visualizations that you can produce in the Jupyter Notebook. A total of 14 outputs can be generated. | ||
|
|
||
| * *Domain Analysis* - provides information about what has been crawled (e.g. which domains) and how often. |
There was a problem hiding this comment.
Should we capitalize the first word after the hyphen for each of these?
ianmilligan1
suggested changes
Mar 7, 2019
README.md
Outdated
|
|
||
| There are several types of visualizations that you can produce in the Jupyter Notebook. A total of 14 outputs can be generated. | ||
|
|
||
| * *Domain Analysis* - provides information about what has been crawled (e.g. which domains) and how often. |
README.md
Outdated
|
|
||
| There are several types of visualizations that you can produce in the Jupyter Notebook. A total of 14 outputs can be generated. | ||
|
|
||
| * *Domain Analysis* - provides information about what has been crawled (e.g. which domains) and how often. |
There was a problem hiding this comment.
Maybe change the - to a : in the list
i.e.
- Domain Analysis: Provides information about what has been crawled (e.g. which domains) and how often.
and same for the other items in this bullet-pointed list.
README.md
Outdated
|
|
||
| This repository also uses the [Jupyter Docker Stacks](https://jupyter-docker-stacks.readthedocs.io/en/latest/index.html), which provide [a lot of helpful options to take advantage of](https://jupyter-docker-stacks.readthedocs.io/en/latest/using/common.html#docker-options). | ||
| This repository also uses the [Jupyter Docker Stacks](https://jupyter-docker-stacks.readthedocs.io/en/latest/index.html), which provide some helpful options for [customizing](https://jupyter-docker-stacks.readthedocs.io/en/latest/using/common.html#docker-options) the container environment. |
ruebot
approved these changes
Mar 7, 2019
ianmilligan1
approved these changes
Mar 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #23 and comes on the heels of additions/modifications made by @ruebot in issue #32
This pull requests does the following:
Thanks for the second and third set of eyes!!