Allow pip to intall source packages if there are no binaries #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @lpsinger, merge main, that should fix the breakage from recently deprecated runtimes. Thanks! |
Remove the `--only-binary=:all:` flag from the `pip install` command. This option prevents pip from installing _any_ packages from binary wheels, even those packages that only have source distributions or that lack binary wheels for the target platform. Note that with this change there _is_ a risk that when hydrating for a foreign architecture (e.g. when hydrating for aarch64 deployment on an i86_64 system) that pip may build wheels for the wrong architecture if compilers are not properly configured for cross-compilation. However, with this change it is at _least_ possible to build packages from source when necessary and when the host and target archs match. For concreteness, we encountered the bug that this patch fixes when we were trying to hydrate a package that depends on [logbook 1.7.0](https://pypi.org/project/Logbook/1.7.0.post0/#files) for aarch64, because that package has no aarch64 wheels at all.
lpsinger
force-pushed
the
remove-no-binary-all
branch
from
3b93e17 to
0d86aa3
Compare
|
Closing in favor of #186. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
--only-binary=:all:flag from thepip installcommand. This option prevents pip from installing any packages from binary wheels, even those packages that only have source distributions or that lack binary wheels for the target platform.Note that with this change there is a risk that when hydrating for a foreign architecture (e.g. when hydrating for aarch64 deployment on an i86_64 system) that pip may build wheels for the wrong architecture if compilers are not properly configured for cross-compilation.
However, with this change it is at least possible to build packages from source when necessary and when the host and target archs match.
For concreteness, we encountered the bug that this patch fixes when we were trying to hydrate a package that depends on logbook 1.7.0 for aarch64, because that package has no aarch64 wheels at all.
Thank you for helping out! ✨
We really appreciate your commitment to improving Architect
To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:
masternpm itfrom the repo root)readme.md, help docs, inline docs & comments, etc.)changelog.mdPlease also be sure to completed the CLA (if you haven't already).
Learn more about contributing to Architect here.
Thanks again!