Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start custom-domain doc #751

Merged
merged 2 commits into from
Nov 12, 2024
Merged

start custom-domain doc #751

merged 2 commits into from
Nov 12, 2024

Conversation

tbeseda
Copy link
Member

@tbeseda tbeseda commented Oct 23, 2024

Thank you for helping out! ✨

We really appreciate your commitment to improving Architect

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

  • Forked the repo and created your branch from main
  • Made sure tests pass (run npm it from the repo root)
  • Updated relevant documentation internal to this repo (e.g. readme.md, help docs, inline docs & comments, etc.)
  • Linked to any related issues, PRs, etc. below that may relate to, consume, or necessitate these changes

Please also be sure to completed the CLA as it's required for your PR to be merged. A github comment will prompt you if you haven't already.

Learn more about contributing to Architect here.

Thanks again!

@ryanblock ryanblock marked this pull request as ready for review November 12, 2024 22:06
@ryanblock ryanblock merged commit 7d5d374 into main Nov 12, 2024
7 checks passed
@ryanblock ryanblock deleted the tbeseda/custom-domain-doc branch November 12, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants