Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add breadcrumbs support #14

Merged
merged 1 commit into from
Dec 20, 2023
Merged

add breadcrumbs support #14

merged 1 commit into from
Dec 20, 2023

Conversation

aine-etke
Copy link
Contributor

@aine-etke
Copy link
Contributor Author

@archdx could you review this, please?

@archdx
Copy link
Owner

archdx commented Dec 20, 2023

thanks, merging

@archdx archdx merged commit a41ff05 into archdx:master Dec 20, 2023
3 checks passed
@ezr-ondrej
Copy link
Contributor

Hi 👋 we're seeing quite a few panics because of this 😛
Yeah, it's bit our fault, because we've got Trace level enabled in our staging (THERE ARE REASONS! 🤣)

This is a fix: #15
And I've noticed we've added the support just for Write and not WriteLevel so I wanted to be a good citizen and added support in WriteLevel too #16

I thought of how to test the AddBreadcrumbs method, but no good ideas, so I didn't :)

@aine-etke aine-etke mentioned this pull request Feb 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aine-etke @archdx @ezr-ondrej