Update memory_set
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eneric params of mapping structures into `MappingBackEnd` as associated types
|
Making generic params associated types of |
equation314
reviewed
Aug 20, 2024
hky1999
reviewed
Aug 20, 2024
Merged
* demo: what if we add more bounds to `MemoryAddr` * remove arithmetic bounds for `MemoryAddr`, add some provided methods * rename `MemoryAddr::sub_addr` to `MemoryAddr::offset_from` * remove a wrong bug todo * add two more functions to `VirtAddr` * add `add` and `sub` to `MemoryAddr` * clarify the behavior of arithmetic operations of `MemoryAddr`, add detailed unit tests * formatted * add `overflowing_add/sub` to `MemoryAddr` * add `checked_add/sub` to `MemoryAddr` * `AddrRange` candidate B: allow malformed ranges and treat them as empty * doc and tests improvement for `MemoryAddr` and `AddrRange` * update `PageIter` * formatted * even more tests, ready to merge * switch to `AddrRange` candidate A
…oryAddr` and `AddrRange`
|
Ready to merge now. |
hky1999
previously approved these changes
Aug 26, 2024
equation314
previously approved these changes
Aug 26, 2024
|
Why don't you return error in memory_area's shink operations anymore? I think returning an Error here is more appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memory_addras dependecy ofmemory_set,FforFlagsandPforPageTable) intoMappingBackEndas associated types, namely:Addr: MemoryAddr, the address type,Flags: Copy, the flags, andPageTable, the page table type.