Support ethernet driver: fxmac for PhytiumPi #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliott10
force-pushed
the
phtpi-tag-v0.1.0
branch
from
be4d4e2 to
93ed37f
Compare
elliott10
force-pushed
the
phtpi-tag-v0.1.0
branch
from
93ed37f to
c1f0c8c
Compare
|
Added interface of crate crate_interface for fxmac net driver |
equation314
reviewed
Feb 24, 2025
| pub fn init(mapped_regs: usize) -> DevResult<Self> { | ||
| info!("FXmacNic init @ {:#x}", mapped_regs); | ||
| let rx_buffer_queue = VecDeque::with_capacity(QS); | ||
| let hwaddr: [u8; 6] = [0x98, 0x0e, 0x24, 0x00, 0x11, 0x0]; |
There was a problem hiding this comment.
Can we avoid hardcoding MAC address?
| @@ -0,0 +1,139 @@ | |||
| use crate::{EthernetAddress, NetBufPtr, NetDriverOps}; | |||
There was a problem hiding this comment.
Organize crates Import order: first core/alloc, then external crates, then crate::*/super::*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ethernet driver: fxmac for PhytiumPi
Added feature: fxmac
Implemented NIC fxmac interface: FXmacDriver
Related PR: arceos-org/arceos#222