Allow oneof for any schemas #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
reviewed
Oct 22, 2024
jaredoconnell
force-pushed
the
allow-oneof-for-any
branch
from
e851270 to
d995e3d
Compare
dbutenhof
reviewed
Dec 10, 2024
dbutenhof
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
Oneof schemas should behave acceptably when used. They should provide the data in a map format with the discriminator inlined.
This will allow oneof types to be inputted to the
wait_forfield.If we need a type that doesn't permit oneof types, we could add more specific types.
By contributing to this repository, I agree to the contribution guidelines.