capture subprocess failures from ansible_runner #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
approved these changes
Nov 6, 2024
| if r.rc != 0: | ||
| # print(r.stderr.read()) | ||
| return "error", ErrorOutput( | ||
| f"Unable to gather facts: ({r.rc}) {r.stdout.read()}" |
There was a problem hiding this comment.
It really comes on stdout rather than stderr?? 🫤 If you say so. The documentation claims there are both stderr and stdout properties ... so is the error really be reported on stdout? That's ... ugly.
There was a problem hiding this comment.
I set this originally to r.sdterr.read() and it was empty and I was sad.
There was a problem hiding this comment.
I'm getting the impression that this is a crappy library lightly wrapped around subprocess, and I should maybe just rewrite this to use subprocess directly instead.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jaredoconnell
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
The
ansible_runnerfunction can have an error condition that does not create an exception. This change adds a check for the return code of the subprocess and returns a plugin error if this is not 0.By contributing to this repository, I agree to the contribution guidelines.