Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math and comparisons #23

Merged
merged 51 commits into from
Feb 2, 2024
Merged

Math and comparisons #23

merged 51 commits into from
Feb 2, 2024

Conversation

jaredoconnell
Copy link
Contributor

Changes introduced with this PR

This PR:

  • Adds missing literals (bool and float)
  • Adds binary math, comparison, and logical operators
  • Adds unary operators (negation and not)

For the convenience of the reader, I created comments that show the tree structure in the grammar section.

Things to note:

  • Typing is struct with binary operations. If you want to mix types, you need to use a cast function.

By contributing to this repository, I agree to the contribution guidelines.

@jaredoconnell
Added functions to grammar only, and removed () around sub-expr
c9a750f
@jaredoconnell
Finished evaluation of expressions
5d1b5ff
@jaredoconnell
Added support for function type and dependency resolution
9374a44
@jaredoconnell
Fix missing NoError assertions
96b65c1
@jaredoconnell
Update to latest SDK
b2638b2
@jaredoconnell
Finished grammar for comparisons, logical operators, math, and booleans
49fa66c
@jaredoconnell
Fix test and tree comment
a6c53e7
@jaredoconnell
Added test for eat failure case
2e958c5
@jaredoconnell
Fix test case broken by recent changes
01bb0f7
@jaredoconnell
Added initial eval for integer math, and added floats
5c7fc3a
@jaredoconnell
Merge branch 'main' into math-and-comparisons
4154408
@jaredoconnell
Added evaluation of operators with bools or strings
6bfaaf3
@jaredoconnell
Added tests for binary operator evaluation
94782ce
@jaredoconnell
Added unary operator evaluation
d65ba81
@jaredoconnell
Revert change to support older go versions
53319d3
@jaredoconnell
Properly track dependencies
eefe8f9
@jaredoconnell
Properly handle paths with extraneous data
048a910
@jaredoconnell
Fix missed error check
aeff7ac
@jaredoconnell
Improved test converage, fixed bugs
db5aabe
@jaredoconnell
Reduce redundancy, improve clarity, and better extraneous path solution
781c026
@jaredoconnell
Remove old code
0048692
@jaredoconnell
Merge branch 'main' into math-and-comparisons
4aed823
@jaredoconnell
Merge branch 'improved-dependency-resolution' into math-and-comparisons
858f1d9
@jaredoconnell
Untested dependency eval for binary and unary ops
78b453d
@jaredoconnell
Merge branch 'main' into math-and-comparisons
5e115e3
@jaredoconnell
Finish tests for type and dependency resolution
65e2c81
@jaredoconnell
Undo line deletion
0e615e8
@jaredoconnell
Undo line deletion
5869188
@jaredoconnell
Fix copy-paste comment error
4b40f22
@jaredoconnell
Added missing not logic
1012a08
jaredoconnell

This comment was marked as resolved.

Sign in to view

webbnh

This comment was marked as resolved.

Sign in to view

webbnh

This comment was marked as resolved.

Sign in to view

webbnh

This comment was marked as resolved.

Sign in to view

dbutenhof
dbutenhof reviewed Jan 31, 2024
View reviewed changes
webbnh

This comment was marked as resolved.

Sign in to view

webbnh

This comment was marked as resolved.

Sign in to view

@jaredoconnell jaredoconnell mentioned this pull request Feb 1, 2024
Open
webbnh

This comment was marked as resolved.

Sign in to view

webbnh
webbnh approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaredoconnell jaredoconnell merged commit 2499906 into main Feb 2, 2024
2 checks passed
@jaredoconnell jaredoconnell deleted the math-and-comparisons branch February 2, 2024 16:25
This was referenced May 15, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@webbnh webbnh webbnh approved these changes

@mfleader mfleader mfleader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaredoconnell @webbnh @dbutenhof @mfleader