Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s dependencies to get rid of indirect mergo dependency #74

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

webbnh
Copy link
Contributor

@webbnh webbnh commented Jan 27, 2025

Changes introduced with this PR

This PR was generated by running go get k8s.io/[email protected] and then go get -t ./... && go mod tidy. It updates the direct dependencies on the k8s.io packages to the next minor version. This has the highly desirable effect of removing the indirect dependency on the mergo package, which has caused so much inconvenience. (I'm not sure why the Renovate bot never proposed this update. 😢 Thanks so much to @mfleader, for pointing this out!!)


By contributing to this repository, I agree to the contribution guidelines.

@webbnh webbnh self-assigned this Jan 27, 2025
Copy link

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since everything seems to pass, that looks like a win. 👍🏻

@webbnh webbnh merged commit 8e6eed9 into main Jan 29, 2025
2 checks passed
@webbnh webbnh deleted the remove-mergo branch January 29, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants