Make the BruteForce interface uniform with BoundingVolumeHierarchy with respect to TraversalPolicy #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chy with respect to TraversalPolicy
dalg24
requested changes
Oct 31, 2023
Comment on lines
-64
to
+65
| Callback const &callback, Ignore = Ignore()) const; | ||
| Callback const &callback, | ||
| Experimental::TraversalPolicy const &policy = | ||
| Experimental::TraversalPolicy()) const; |
There was a problem hiding this comment.
Experimental::TraversalPolicy makes absolutely no sense for BruteForce. This was literally the point of that Ignore parameter.
There was a problem hiding this comment.
It just doesn't make much sense to me to have a user-exposed template parameter that allows passing in arbitrary types that are entirely ignored.
|
What issue is that resolving? The |
|
We hope to refactor the interface for BVH that might get rid of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #962 (comment). We can't really check the values here since we would like to pass values that are only relevant for BVH.