Update triangle example to API v2 #936
Conversation
aprokop
force-pushed
the
apiv2_triangle_intersection_example
branch
from
b7fec02 to
6a7253e
Compare
aprokop
force-pushed
the
apiv2_triangle_intersection_example
branch
from
6a7253e to
b79de0f
Compare
|
The example is still probably too complex. Would probably want to do a smaller one with just a few triangles and few points and no callback. It really depends on what we want. |
aprokop
force-pushed
the
apiv2_triangle_intersection_example
branch
from
b79de0f to
5bb9bcd
Compare
Did just this. 8 triangles, 9 points. Not very different from the simple intersection example, just slightly more complicated. I think it's fine. If desired, we could convert the previous example into a benchmark. |
aprokop
force-pushed
the
apiv2_triangle_intersection_example
branch
from
5bb9bcd to
5519ff5
Compare
| // _____________ | ||
| // |\ x |\ x| | ||
| // | \ | \ | | ||
| // |____\|____\| | ||
| // |\ |\ | | ||
| // | \ x|x \ | | ||
| // _____\|____\| |
There was a problem hiding this comment.
You didn't want to number them?
There was a problem hiding this comment.
I tried it, but found that it was hard to distinguish from triangle numbering. It seemed like it you need both x and number for clarity. So, I decided to drop the numbers.
|
Note that this PR should also fix the intermittent failures of the triangle intersection test on SYCL. |
Creating so that I won't forget. Depends on #915 and #944.