Make sure ARBORX_VERSION and ARBORX_VERSION_STRING always match #1201
Conversation
aprokop
added
build
src/ArborX_Config.hpp.in
Outdated
| #define ARBORX_VERSION_MAJOR @ARBORX_VERSION_MAJOR@ | ||
| #define ARBORX_VERSION_MINOR @ARBORX_VERSION_MINOR@ | ||
| #define ARBORX_VERSION_PATCH @ARBORX_VERSION_PATCH@ |
There was a problem hiding this comment.
Not sure if we need these, but should not hurt.
|
Also please add a static_assert(0 <= ARBORX_VERSION_MAJOR && ARBORX_VERSION_MAJOR <= 99);
// ...
static_assert(ARBORX_VERSION == ARBORX_VERSION_MAJOR * 10000 + ...); |
Yes. I am not sure how to express that. Or any breaking changes in the future. Other than through version major. |
aprokop
force-pushed
the
arborx_version_followup
branch
from
ac40b2e to
31857fd
Compare
| @@ -0,0 +1,21 @@ | |||
| #include <ArborX_Config.hpp> | |||
There was a problem hiding this comment.
Should we be including <Arborx.hpp> instead?
There was a problem hiding this comment.
I think either is fine. ArborX_Config.hpp is still the top level file at the moment, so users are allowed to include it without including ArborX.hpp, I think.
| #ifndef ARBORX_VERSION | ||
| static_assert(false, "ARBORX_VERSION macro is not defined!"); | ||
| #endif | ||
|
|
||
| #ifndef ARBORX_VERSION_MAJOR | ||
| static_assert(false, "ARBORX_VERSION_MAJOR macro is not defined!"); | ||
| #endif | ||
|
|
||
| #ifndef ARBORX_VERSION_MINOR | ||
| static_assert(false, "ARBORX_VERSION_MINOR macro is not defined!"); | ||
| #endif | ||
|
|
||
| #ifndef ARBORX_VERSION_PATCH | ||
| static_assert(false, "ARBORX_VERSION_PATCH macro is not defined!"); | ||
| #endif |
There was a problem hiding this comment.
These are fine if you really want them but it is covered by the static assertions below.
Follow-up on #1190. Make versions consistent.