Fix hardcoded floats in TreeTraversal #1195
Merged
+21
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
force-pushed
the
fix_hardcoded_floats_tree_traversal
branch
from
3eded6d to
231a61f
Compare
aprokop
force-pushed
the
fix_hardcoded_floats_tree_traversal
branch
from
231a61f to
5164118
Compare
The status quo resulted in the following error with CUDA 11.5.2:
/var/jenkins/workspace/ArborX_PR-1195/src/spatial/detail/ArborX_TreeTraversal.hpp:157:64: error: '__T288' was not declared in this scope
157 | _buffer =
| ^
/var/jenkins/workspace/ArborX_PR-1195/src/spatial/detail/ArborX_TreeTraversal.hpp:157:70: error: template argument 2 is invalid
157 | _buffer =
| ^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure whether to classify it as a bug or not. Essentially, we've been using reduced precision inside nearest query when running with
double. All distances were calculated and converted to floats. It could lead to wrong results when two different doubles are converted to the same floatNeed to figure out how to test it.