Fix a temporary objects issue with DefaultIndexableGetter #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 0fdfa87, we addressed the temporaries issues when passing around PairIndexObject. What we didn't realize at the time, that similar issues could have been present in the geometries part too. This was shown to break behavior of the FDBSCAN-DenseBox when called with primitives assembled on the fly using AccessTraits. In that case, the scene bounding box was completely wrong, resulting in random asserts.
Closed
dalg24
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0fdfa87 (part of #915), we addressed the temporaries issues when passing around
PairValueIndex. What we didn't realize at the time, that similar issuescould have been present in the geometries part too.
This was shown to break behavior of the FDBSCAN-DenseBox when called
with primitives assembled on the fly using
AccessTraits. In that case,the scene bounding box was completely wrong, resulting in random
asserts.
This only makes ArborX internally work. I'm not sure if we still have a potential issue when a user defines their own indexable getter. I'm not confident I understand the intricacies of what's going on.