Fix warnings for nvcc

arborx · Jun 13, 2024 · 2f0e70c · 2f0e70c
1 parent a403dad
commit 2f0e70c
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 3 deletions.
diff --git a/src/interpolation/details/ArborX_InterpDetailsPolynomialBasis.hpp b/src/interpolation/details/ArborX_InterpDetailsPolynomialBasis.hpp
@@ -95,8 +95,13 @@ KOKKOS_FUNCTION constexpr std::size_t polynomialBasisSize()
   static_assert(DIM > 0, "Polynomial basis with no dimension is invalid");
 
   std::size_t result = 1;
-  for (std::size_t k = 0; k < Kokkos::min(DIM, Degree); ++k)
-    result = result * (DIM + Degree - k) / (k + 1);
+
+  constexpr auto D = Kokkos::min(DIM, Degree);
+  if constexpr (D > 0)
+  {
+    for (std::size_t k = 0; k < D; ++k)
+      result = result * (DIM + Degree - k) / (k + 1);
+  }
   return result;
 }
 

diff --git a/test/tstCompileOnlyAccessTraits.cpp b/test/tstCompileOnlyAccessTraits.cpp
@@ -86,6 +86,8 @@ void test_access_traits_compile_only()
   struct CustomIndex
   {
     char index;
+
+    KOKKOS_FUNCTION
     CustomIndex(int i) { index = i; }
   };
   auto q_with_custom_indices =

diff --git a/test/tstDendrogram.cpp b/test/tstDendrogram.cpp
@@ -142,7 +142,7 @@ BOOST_AUTO_TEST_CASE_TEMPLATE(dendrogram_boruvka, DeviceType,
 
     auto permute = sortObjects(space, weights);
 
-    Kokkos::View<unsigned *, MemorySpace> inv_permute(
+    Kokkos::View<int *, MemorySpace> inv_permute(
         Kokkos::view_alloc(space, Kokkos::WithoutInitializing,
                            "Testing::inv_permute"),
         n - 1);

diff --git a/test/tstQueryTreeCallbacks.cpp b/test/tstQueryTreeCallbacks.cpp
@@ -135,6 +135,9 @@ BOOST_AUTO_TEST_CASE_TEMPLATE(callback_nearest_predicate, TreeTypeTraits,
       Kokkos::RangePolicy<ExecutionSpace>(0, n), KOKKOS_LAMBDA(int i) {
         points(i) = {{(float)i, (float)i, (float)i}};
       });
+#ifdef KOKKOS_COMPILER_NVCC
+  [[maybe_unused]]
+#endif
   ArborX::Point const origin = {{0., 0., 0.}};
 
   auto values = initialize_values(points, /*delta*/ 0.f);
@@ -308,6 +311,9 @@ BOOST_AUTO_TEST_CASE_TEMPLATE(callback_with_attachment_nearest_predicate,
         points(i) = {{(float)i, (float)i, (float)i}};
       });
   float const delta = 5.f;
+#ifdef KOKKOS_COMPILER_NVCC
+  [[maybe_unused]]
+#endif
   ArborX::Point const origin = {{0., 0., 0.}};
 
   auto values = initialize_values(points, delta);