Dev #99
Open
Dev #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make required changes to support new 0.2.3-dev API.
Update for new cable_cell API pending 0.2.3 release.
* Implement RMS error computation in `comparex`. * Add new validation test 'rallpack1' (see `validation/rallpack1/README.md`) for NEURON and Arbor.
* Add new validation test 'cable-steadystate': cable with Rallpack1 electrical characteristics, but with differing diameters at each end; simulations are run to steady-state (20 times cable time constant) and compared against analytical solution.
* Add selection switch for ARB_GPU. * Make building validation code optional via `ns_validate` shell variable in environment script.
|
I like these changes! The only thing left out would be the removal of |
bcumming
requested changes
Apr 30, 2020
There was a problem hiding this comment.
One small comment.
Don't forget the documentation in the docs/ path:
https://github.com/arbor-sim/nsuite/blob/master/docs/install.rst
scripts/environment.sh
Outdated
| @@ -71,7 +71,6 @@ default_environment() { | |||
|
|
|||
| ns_arb_arch=native | |||
| ns_arb_with_gpu=OFF | |||
| ns_arb_gpu=none | |||
There was a problem hiding this comment.
How about keeping this variable, and allowing it to be set to none, cuda, hip or clang-cuda, and passing it directly to CMake:
cmake -DARB_GPU=$ns_arb_gpu
There was a problem hiding this comment.
I decided on using ns_arb_with_gpu for this purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean-up of previous update