simplify partial_transpose

araujoms · Jun 18, 2024 · 6c957f1 · 6c957f1
1 parent dd87589
commit 6c957f1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/partial_tra.jl b/src/partial_tra.jl
@@ -118,8 +118,8 @@ export partial_trace
 Takes the partial transpose of matrix `X` with subsystem dimensions `dims` on the subsystems in `transp`.
 """ partial_transpose
 
-for (T, symmetry, wrapper) in
-    [(:AbstractMatrix, :false, :identity), (:(LA.Hermitian), :true, :(LA.Hermitian)), (:(LA.Symmetric), :true, :(LA.Symmetric))]
+for (T, wrapper) in
+    [(:AbstractMatrix, :identity), (:(LA.Hermitian), :(LA.Hermitian)), (:(LA.Symmetric), :(LA.Symmetric))]
     @eval begin
         function partial_transpose(X::$T, transp::Vector{<:Integer}, dims::Vector{<:Integer})
             isempty(transp) && return X
@@ -161,7 +161,7 @@ for (T, symmetry, wrapper) in
 
                     Xi, Xj = _idx(tXi, dims), _idx(tXj, dims)
                     Y[i, j] = X[Xi, Xj]
-                    !($symmetry) && (Y[j, i] = X[Xj, Xi])
+                    i != j && (Y[j, i] = X[Xj, Xi])
                 end
             end
             return $wrapper(Y)

diff --git a/test/partial_tra.jl b/test/partial_tra.jl
@@ -31,7 +31,7 @@
     end
 end
 
-@testset "Partial Transpose" begin
+@testset "Partial transpose" begin
     d1, d2, d3 = 2, 3, 4
     for R in [Float64, Double64, Float128, BigFloat]
         for T in [R, Complex{R}]