Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE-756 | optimizeTopK View [3.12] #323

Merged
merged 7 commits into from
Apr 26, 2024
+17 −1
Merged

DE-756 | optimizeTopK View [3.12] #323

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
47b5500
DE-756 | initial commit
aMahanna Feb 2, 2024
2d65097
Merge branch 'main' into DE-756
aMahanna Apr 23, 2024
ea99850
Merge branch 'main' into DE-756
aMahanna Apr 26, 2024
bc9aef9
fix: import
aMahanna Apr 26, 2024
6b4d289
fix: test on 3.12 only
aMahanna Apr 26, 2024
f009f50
fix: add delete_view
aMahanna Apr 26, 2024
8fd0b24
add enterprise condition
aMahanna Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tests/test_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from tests.helpers import assert_raises, generate_view_name


def test_view_management(db, bad_db, col, cluster):
def test_view_management(db, bad_db, col, cluster, db_version):
# Test create view
view_name = generate_view_name()
bad_view_name = generate_view_name()
Expand Down Expand Up @@ -124,6 +124,19 @@ def test_view_management(db, bad_db, col, cluster):
# Test delete missing view with ignore_missing set to True
assert db.delete_view(view_name, ignore_missing=True) is False

if db_version >= version.parse("3.11"):
res = db.create_view(
view_name,
view_type,
properties={
"links": {col.name: {"fields": {}}},
"optimizeTopK": [
"BM25(@doc) DESC",
],
},
)
assert "optimizeTopK" in res
aMahanna marked this conversation as resolved.
Show resolved Hide resolved


def test_arangosearch_view_management(db, bad_db, cluster):
# Test create arangosearch view
Expand Down
Loading