Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] IXI-to-BIDS function define_participants should output sorted participants list #1318

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[FIX] IXI-to-BIDS function define_participants should output sorted participants list #1318

merged 1 commit into from
Oct 9, 2024

Conversation

AliceJoubert
Copy link
Contributor

@AliceJoubert AliceJoubert commented Oct 9, 2024 •
edited by NicolasGensollen
Loading

Closes #1317

@AliceJoubert AliceJoubert added bug Something isn't working converter labels Oct 9, 2024
@AliceJoubert AliceJoubert self-assigned this Oct 9, 2024
@NicolasGensollen NicolasGensollen added fix PR fixing a bug and removed bug Something isn't working labels Oct 9, 2024
NicolasGensollen
NicolasGensollen approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AliceJoubert !

@NicolasGensollen NicolasGensollen merged commit 9ed92e5 into aramis-lab:dev Oct 9, 2024
14 of 15 checks passed
@AliceJoubert AliceJoubert deleted the ixi_order_prtcp branch October 9, 2024 12:46
@NicolasGensollen NicolasGensollen mentioned this pull request Oct 9, 2024
Closed
@NicolasGensollen NicolasGensollen added this to the v0.9.2 milestone Oct 24, 2024
NicolasGensollen pushed a commit to NicolasGensollen/clinica that referenced this pull request Oct 24, 2024
@AliceJoubert @NicolasGensollen
[FIX] IXI-to-BIDS function define_participants should output sorted…
3772efd 
… participants list (aramis-lab#1318)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasGensollen NicolasGensollen NicolasGensollen approved these changes

Assignees

@AliceJoubert AliceJoubert

Labels
converter fix PR fixing a bug
Projects
None yet
Milestone
v0.9.2
Development

Successfully merging this pull request may close these issues.

[BUG] The function define_participants return value is not deterministic
2 participants
@AliceJoubert @NicolasGensollen