Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONV] IXI-to-BIDS modifications to fit BIDS specifications 1.10 #1310

Merged

Conversation

AliceJoubert
Copy link
Contributor

@AliceJoubert AliceJoubert commented Oct 1, 2024

TODO :

  • Add missing DWI b files (see inheritance principle since same values for all files)
  • Fix TSV format
  • Update unit tests
  • Update regression tests

Data PR: https://github.com/aramis-lab/clinica_data_ci/pull/72

@AliceJoubert AliceJoubert self-assigned this Oct 1, 2024
@AliceJoubert AliceJoubert marked this pull request as ready for review October 2, 2024 14:56
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @AliceJoubert !
The PR LGTM. I suppose the non regression test for ixi-to-bids is going to fail and you will open a data PR to add the bvec and bval files to the CI data, right ?

@AliceJoubert
Copy link
Contributor Author

Thanks for the review @NicolasGensollen ! Yes absolutely ^^

@NicolasGensollen
Copy link
Member

Alright ! Tests are passing with the new data.
Merging...

@NicolasGensollen NicolasGensollen merged commit 0d4309b into aramis-lab:dev Oct 3, 2024
14 of 15 checks passed
@AliceJoubert AliceJoubert deleted the ixi_converter_bids1.10 branch October 3, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants