Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Use ruff for linting and formatting #1032

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

ghisvail
Copy link
Collaborator

@ghisvail ghisvail commented Dec 7, 2023

Ruff is now the Swiss-army knife for linting and formatting a Python codebase.

This PR proposes to replace black, flake8 and isort with ruff, whilst keeping a similar configuration.

More rules could be enabled later to gradually increase the strictness of the linting. For instance, running pydocstyle checks with the numpy convention to verify our docstrings.

@NicolasGensollen NicolasGensollen added the enhancement New feature or request label Dec 11, 2023
@NicolasGensollen NicolasGensollen self-requested a review December 11, 2023 12:25
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ghisvail !

Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ghisvail !

@ghisvail ghisvail merged commit f1079e0 into aramis-lab:dev Dec 14, 2023
14 of 17 checks passed
@ghisvail ghisvail deleted the maint/ruff branch December 14, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants