MAINT: Use flake8 pre-commit hook over pep8speaks #1026
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up flake8 with pre-commit and drops
pep8speaks
.The latter did let a few
pycodestyle
errors and warnings pass by, which gives me little trust in the tool for the long term. Instead, let's rely on the official pre-commit hook forflake8
and use the same config used withpep8speaks
. It might be worth adding some more checks later (theselect
option) than justpycodestyle
errors (E
) and warnings (W
).