Feature/rd 1193 add openzeppelin foundry upgrades to the repo #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavikh
commented
Feb 10, 2025
| @@ -382,12 +383,12 @@ contract GaugesDaoFactoryTest is Test { | |||
|
|
|||
| TokenParameters[] memory tokenParameters = new TokenParameters[](2); | |||
| tokenParameters[0] = TokenParameters({ | |||
| token: address(deployMockERC20("T1", "T1", 18)), | |||
There was a problem hiding this comment.
deployMockERC20 was deprecated on the new version of forge-std
xavikh
commented
Feb 10, 2025
| @@ -29,6 +29,7 @@ contract Clock is IClock, DaoAuthorizable, UUPSUpgradeable { | |||
| Initialization | |||
| //////////////////////////////////////////////////////////////*/ | |||
|
|
|||
| /// @custom:oz-upgrades-unsafe-allow constructor | |||
There was a problem hiding this comment.
This annotation is needed in all the contracts with a constructor (also in the old ones)
xavikh
force-pushed
the
feature/rd-1193-add-openzeppelin-foundry-upgrades-to-the-repo
branch
from
dd64db6 to
de71bbc
Compare
xavikh
force-pushed
the
feature/rd-1193-add-openzeppelin-foundry-upgrades-to-the-repo
branch
from
7cf5a12 to
dc6fbf8
Compare
xavikh
force-pushed
the
feature/rd-1193-add-openzeppelin-foundry-upgrades-to-the-repo
branch
from
e707746 to
70c3555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.