WIP: Feat: Offchain DAO creation #957

selankon · 2023-08-03T06:57:21Z

Description

This PR is developed on the vocdoni offChain plugin context.

The branch implement changes on the DAO creation form to add the option to create offChain proposals with a executive committee.

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

I have selected the correct base branch.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
Any dependent changes have been merged and published in downstream modules.
I ran all tests with success and extended them if necessary.
I have updated the CHANGELOG.md file in the root folder.
I have tested my code on the test network.

CLAassistant · 2023-08-03T06:57:27Z

All committers have signed the CLA.

elboletaire

Some of the useMemo and useCallbacks used are not necessary. Ensure you try any changes to these methods, since I can only speak for the code I've seen... I tried to check all the affected methods to ensure I'm not saying it wrong, but I could be wrong in some of them... so double-check it please.

package.json

src/components/addCommitteeMembers/index.tsx

src/components/executionExpirationtime/index.tsx

src/components/filteredAddressList/index.tsx

src/containers/goLive/committee.tsx

src/context/createDao.tsx

src/components/addCommitteeMembers/row.tsx

elboletaire · 2023-09-22T11:59:46Z

src/pages/createDAO.tsx

+  const defineCommitteeIsValid = useMemo(() => {
+    if (
+      !committee ||
+      !committee.length ||
+      errors.committee ||
+      errors.committeeMinimumApproval ||
+      errors.executionExpirationMinutes ||
+      errors.executionExpirationHours ||
+      errors.executionExpirationDays
+    )
+      return false;
+    return true;
+  }, [
+    committee,
+    errors.committee,
+    errors.committeeMinimumApproval,
+    errors.executionExpirationMinutes,
+    errors.executionExpirationHours,
+    errors.executionExpirationDays,
+  ]);
+
+  const proposalCreationIsValid = useMemo(() => {
+    // required fields not dirty
+    // if multisig
+    if (membership === 'multisig') {
+      if (!['multisig', 'anyone'].includes(eligibilityType)) {
+        return false;
+      }
+      return true;
+    } else {
+      return !errors.eligibilityTokenAmount;
+    }
+  }, [eligibilityType, errors.eligibilityTokenAmount, membership]);


No need to use useMemo here.

selankon · 2023-10-30T11:52:52Z

Closed in favour to #1074

selankon requested a review from sepehr2github August 3, 2023 06:57

emmdim self-requested a review August 3, 2023 09:56

selankon force-pushed the f/offchain-DAO-creation branch 3 times, most recently from 70d2a5a to ce547ff Compare August 7, 2023 11:05

selankon changed the base branch from develop to f/offchain-plugin August 8, 2023 10:36

selankon force-pushed the f/offchain-DAO-creation branch 2 times, most recently from b5c67e2 to 98ec3b1 Compare August 10, 2023 07:59

selankon force-pushed the f/offchain-plugin branch from 1c62dd5 to f889286 Compare August 11, 2023 09:11

selankon force-pushed the f/offchain-DAO-creation branch from 98ec3b1 to 92665b4 Compare August 11, 2023 09:20

selankon force-pushed the f/offchain-plugin branch 2 times, most recently from 9bc270a to f889286 Compare September 1, 2023 09:05

selankon force-pushed the f/offchain-DAO-creation branch from 0d1bd50 to cf37dcf Compare September 1, 2023 11:36

selankon force-pushed the f/offchain-plugin branch from e5eb97a to 4527f50 Compare September 5, 2023 09:27

selankon force-pushed the f/offchain-DAO-creation branch 6 times, most recently from e9774ec to 5d23c8f Compare September 20, 2023 08:29

selankon force-pushed the f/offchain-plugin branch from 38bbc6a to 65d07a3 Compare September 22, 2023 08:34

elboletaire suggested changes Sep 22, 2023

View reviewed changes

selankon force-pushed the f/offchain-DAO-creation branch 2 times, most recently from 9dfb36b to d0e2461 Compare September 27, 2023 09:44

selankon force-pushed the f/offchain-plugin branch 2 times, most recently from 3723975 to af00d3e Compare September 27, 2023 10:36

selankon force-pushed the f/offchain-DAO-creation branch from d0e2461 to 32d3c90 Compare September 27, 2023 10:38

selankon added 2 commits September 27, 2023 14:15

Create votingType selector

6200ab6

Create ProposalCreation component

b794a88

selankon added 23 commits September 27, 2023 14:15

Implement add executive commite wallets

3323272

Implement committee minimum approval

0b8ffb2

Implement execution expiration time

cec4f20

Implement defineCommitteeIsValid

c8cb8cc

Add confirm dao creation step

c937ed0

Use hideWizard for votingType offChain

05be15d

Fix validation when adding committee members

4b8e6ce

Add committee section to goLive

9881234

Create vocdoni census3

eb6b5e8

Implement dao creation only for token holders

6643076

Update rebased components

d7a5bf0

Create committee address modal

5270429

Implement committee review view

c10bcd9

Enable code

33f4156

Disable early execution and vote change for offChain voting

273f7b9

Fix validation errors

12b1708

Check census3 supported chains

9ed6dd0

Install offchain plugin

c543643

WIP disable committee wallet validation

7835288

Implement census3 create token

aaf3568

Fix plugin address

0f57ec3

Disable commite member must be holder

4f3d4e5

Fix types

264140e

selankon force-pushed the f/offchain-DAO-creation branch from 32d3c90 to 264140e Compare September 27, 2023 12:16

selankon added 3 commits October 16, 2023 11:49

Add timeout

2ea8af3

Fix new types on min sdk

c0459b0

Fix if consistency

26c7ced

selankon closed this Oct 30, 2023

selankon deleted the f/offchain-DAO-creation branch November 8, 2023 12:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Feat: Offchain DAO creation #957

WIP: Feat: Offchain DAO creation #957

selankon commented Aug 3, 2023

CLAassistant commented Aug 3, 2023 •

edited

Loading

elboletaire left a comment

elboletaire Sep 22, 2023

selankon commented Oct 30, 2023

WIP: Feat: Offchain DAO creation #957

WIP: Feat: Offchain DAO creation #957

Conversation

selankon commented Aug 3, 2023

Description

Type of change

Checklist:

CLAassistant commented Aug 3, 2023 • edited Loading

elboletaire left a comment

Choose a reason for hiding this comment

elboletaire Sep 22, 2023

Choose a reason for hiding this comment

selankon commented Oct 30, 2023

CLAassistant commented Aug 3, 2023 •

edited

Loading