Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-3758): Transaction failed error for Tx's when connected with Safe account on Ethereum #1416

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

Barukimang
Copy link
Collaborator

@Barukimang Barukimang commented Nov 8, 2024

Description

Was able to reproduce the issue locally, which gave the following error info, see image below. Since the issue seemed Wallet Connect and Viem related did some incremental upgrades until it resolved the issue, see video below.

Image
image

Video

upgrade-viem.mov

Task: APP-3758

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@Barukimang Barukimang requested a review from cgero-eth November 8, 2024 13:25
@cgero-eth cgero-eth merged commit e586fc6 into develop Nov 11, 2024
3 checks passed
@cgero-eth cgero-eth deleted the fix/app-safe-error branch November 11, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants