Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-3649): Replace strings that were removed via mislabel #1411

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Oct 30, 2024

Description

Removed some strings from the locale that were supposedly explorer specific but being used more globally, so replaced. Specifically "Wallet-based" and "Token-based" as DAO type helper label

Task: APP-3649

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@cgero-eth cgero-eth merged commit ca8124e into develop Oct 30, 2024
2 checks passed
@cgero-eth cgero-eth deleted the fix/gov-type-strings branch October 30, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants