Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(APP-3648): Improve Explore page hero section + layout #1409

Merged
merged 19 commits into from
Oct 29, 2024
Merged

feat(APP-3648): Improve Explore page hero section + layout #1409

merged 19 commits into from
Oct 29, 2024

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Oct 27, 2024 •
edited by jira bot
Loading

Description

Update background text, typeface, layout, carousel content, etc

Task: APP-3648

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.

@thekidnamedkd thekidnamedkd changed the title WIP feat(APP-3648): Improve Explore page hero section + layout feat(APP-3648): Improve Explore page hero section + layout Oct 28, 2024
@thekidnamedkd thekidnamedkd requested a review from a team October 28, 2024 12:27
@github-actions GitHub Actions
Copy link

WebApp IPFS Hash: Post
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/Post/

cgero-eth
cgero-eth reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @thekidnamedkd!

index.html Show resolved Hide resolved
src/assets/locales/en/common.json Show resolved Hide resolved
src/components/ctaCard/index.tsx Show resolved Hide resolved
src/containers/hero/index.tsx Show resolved Hide resolved
src/containers/carousel/index.tsx Outdated Show resolved Hide resolved
cgero-eth
cgero-eth approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @thekidnamedkd!

@cgero-eth cgero-eth merged commit 38c5566 into develop Oct 29, 2024
3 checks passed
@cgero-eth cgero-eth deleted the feat/APP-3648 branch October 29, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thekidnamedkd @cgero-eth