Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-3092): Truncate DAO links on settings page #1384

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

Barukimang
Copy link
Collaborator

@Barukimang Barukimang commented Jul 8, 2024

Description

Before (find DAO here)
image

After
image

Task: APP-3092

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@cgero-eth cgero-eth changed the title fix: APP-3092 - DAO Settings Link Box does not truncate copy fix(APP-3092): DAO Settings Link Box does not truncate copy Jul 8, 2024
@cgero-eth cgero-eth changed the title fix(APP-3092): DAO Settings Link Box does not truncate copy fix(APP-3092): Truncate DAO links on settings page Jul 8, 2024
@Barukimang
Copy link
Collaborator Author

Added breaking point so to only repair at xl screens where this was an issue. It is fixed now for all screen sizes, also bit more square sizes (see image below):

Image
image

Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Barukimang!

@cgero-eth cgero-eth merged commit 043c237 into develop Jul 11, 2024
3 checks passed
@cgero-eth cgero-eth deleted the fix/app-3092-truncate-settings branch July 11, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants