Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-3384): Correctly identify OSx updates as latest version #1382

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

cgero-eth
Copy link
Member

@cgero-eth cgero-eth commented Jul 6, 2024

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: APP-3384

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@Barukimang
Copy link
Collaborator

Wlcm back @cgero-eth 😄 Was able to repro the issue @cgero-eth (see image 1 below). Tested with your branch and then it's working (see image 2).

Created Jira ticket for the bug, see here.

Image 1
image

Image 2
image

@cgero-eth cgero-eth requested a review from a team July 8, 2024 07:43
@cgero-eth cgero-eth changed the title WIP fix: Correctly identify OSx updates as latest version fix: Correctly identify OSx updates as latest version Jul 8, 2024
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cgero-eth

@cgero-eth cgero-eth changed the title fix: Correctly identify OSx updates as latest version fix(APP-3384): Correctly identify OSx updates as latest version Jul 8, 2024
@cgero-eth cgero-eth merged commit f94c066 into develop Jul 8, 2024
2 checks passed
@cgero-eth cgero-eth deleted the fix-osx-updates branch July 8, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants