Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-3261): Truncate long link descriptions dashboard #1381

Merged
merged 3 commits into from
Jul 9, 2024
+7 −2
Merged

fix(APP-3261): Truncate long link descriptions dashboard #1381

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56f481e
edit default links shown
Barukimang Jul 5, 2024
e0833d8
fix truncation not working for label description
Barukimang Jul 8, 2024
bdf14e2
removed global link max width and added local class fixing truncation
Barukimang Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
removed global link max width and added local class fixing truncation
@Barukimang
Barukimang committed Jul 9, 2024
commit bdf14e2853b99a6ad7b6e2ff53ef2f9c75a58eb7
7 changes: 6 additions & 1 deletion src/@aragon/ods-old/components/headers/headerDao.tsx
View file
Original file line number Diff line number Diff line change
@@ -207,7 +207,12 @@ export const HeaderDao: React.FC<HeaderDaoProps> = ({
{links
?.slice(0, DEFAULT_LINKS_SHOWN)
?.map(({label, href}, index: number) => (
<Link {...{label, href}} external key={index} />
<Link
className="max-w-44"
{...{label, href}}
external
key={index}
/>
))}
</LinksWrapper>
<ActionContainer>
2 changes: 1 addition & 1 deletion src/@aragon/ods-old/components/link/link.tsx
View file
Original file line number Diff line number Diff line change
@@ -77,7 +77,7 @@ const StyledLink = styled.a.attrs<StyledLinkProps>(({disabled, type}) => {
`;

const Label = styled.span.attrs({
className: 'ft-text-base font-semibold truncate max-w-xs',
className: 'ft-text-base font-semibold truncate',
})``;

const Description = styled.p.attrs({