Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-3285): Fix block explorer links for zkSync chains, align zkSync mainnet chain name with backend #1377

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

cgero-eth
Copy link
Member

@cgero-eth cgero-eth commented Jun 28, 2024

Description

  • Fix token links for zksync and zksync sepolia
  • Rename zksync to zksyncMainnet to keep it in sync with backend

Task: APP-3285

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team June 28, 2024 08:03
@cgero-eth cgero-eth changed the title fix(APP-3285): Fix block explorer links for zkSync chains fix(APP-3285): Fix block explorer links for zkSync chains, align zkSync mainnet chain name with backend Jun 28, 2024
Copy link

WebApp IPFS Hash: Qmb6SCy22oJ4Kz5v987TbtkGBs9w5Z8NtUdgNzoTPeymQr
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/Qmb6SCy22oJ4Kz5v987TbtkGBs9w5Z8NtUdgNzoTPeymQr/

Copy link
Collaborator

@Barukimang Barukimang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @cgero-eth ! Confirmed that all issues which could be fixed from the front-end (see here and here) have been fixed.

@cgero-eth cgero-eth merged commit e9b740c into develop Jun 28, 2024
3 checks passed
@cgero-eth cgero-eth deleted the fix-zksync-block-explorer-links branch June 28, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants