fix: APP-3195 - An empty link is unnecessarily added to Proposal "resources"

[Barukimang]

Description

Found that issue was introduced with new createProposalUtil which would add an object to the resources array even when no link added. This prevented showing empty state since links.length > 0

Proposals before the new util did not have the issue, see here e.g.: proposal link

For these proposals no links object was added to the array. So for the new createProposalUtil added truthy logic preventing an object added to the array when no link present. Compare before and after in the images below:

Before (proposal link)

After (proposal link)

Task: APP-3195

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• Any dependent changes have been merged and published in downstream modules.
• I have tested my code on the test network.

[cgero-eth]

Thanks for the fix @Barukimang!