Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-3263 - zkSync Sepolia uses title case on the DAO list and DAO header and displays as "ZkSync Sepolia" #1370

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

Barukimang
Copy link
Collaborator

@Barukimang Barukimang commented Jun 7, 2024

Description

Lower cased zkSync (both Era and Sepolia) on DAO header and DAO cards while keeping other networks upper cased. Found 7 app instances where CHAIN_METADATA[network].name is rendered. In 5 of them zkSync is already lower cased, fixed the 2 instances where it was upper cased (DAO header and DAO cards).

Dashboard before
image

Dashboard after
image

DAO cards before
image

DAO cards after
image

Task: APP-3263

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@Barukimang Barukimang requested a review from cgero-eth June 7, 2024 14:01
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can we just confirm this doesn't "decapitalize" any of our other networks from the common file? If no side effects 🚀

@Barukimang
Copy link
Collaborator Author

This looks good. Can we just confirm this doesn't "decapitalize" any of our other networks from the common file? If no side effects 🚀

Cool thing: it doesn't :) See image below 👇 Also checked other pages and all bueno.

Image
image

@Barukimang Barukimang closed this Jun 7, 2024
@Barukimang Barukimang reopened this Jun 7, 2024
@Barukimang Barukimang merged commit b548353 into develop Jun 7, 2024
3 checks passed
@Barukimang Barukimang deleted the fix/app-3263-zksync-lower-case branch June 7, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants