Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correctly display voting members with token balances after after SDK update #1355

Merged
merged 3 commits into from
May 23, 2024
Merged

fix: Correctly display voting members with token balances after after SDK update #1355

merged 3 commits into from
May 23, 2024

Conversation

thekidnamedkd
Copy link
Contributor

Description

Split the proposal id from voter address and remove extra use of token symbol in display

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@thekidnamedkd thekidnamedkd requested review from Barukimang and a team May 22, 2024 16:19
@github-actions GitHub Actions
Copy link

WebApp IPFS Hash: QmcWTTun5XczwmRz4DB7fGSdQCVL4Dec3VDt7nbGKmjvTP
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/QmcWTTun5XczwmRz4DB7fGSdQCVL4Dec3VDt7nbGKmjvTP/

sepehr2github
sepehr2github approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@sepehr2github sepehr2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

@thekidnamedkd thekidnamedkd merged commit ff41ca2 into develop May 23, 2024
3 checks passed
@thekidnamedkd thekidnamedkd deleted the fix/tokenvoting-sdk branch May 23, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepehr2github sepehr2github sepehr2github approved these changes

@Barukimang Barukimang Awaiting requested review from Barukimang

Assignees
No one assigned
Labels
preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thekidnamedkd @sepehr2github